feat(files_sharing): add config option for extending link-share permissions #52777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
artonge,
nfebe and
skjnldsv
and removed request for
a team
susnux
added
the
pending documentation
nfebe
reviewed
May 13, 2025
nfebe
reviewed
May 13, 2025
Contributor
nfebe
left a comment
nfebe
left a comment
There was a problem hiding this comment.
Add the config to the config lexicon, so that occ is aware of the configuration via config list : https://github.com/nextcloud/server/blob/master/apps/files_sharing/lib/Config/ConfigLexicon.php
susnux
force-pushed
the
feat/add-config-for-share-perm
branch
from
539f283 to
f32b6d6
Compare
artonge
reviewed
May 27, 2025
susnux
force-pushed
the
feat/add-config-for-share-perm
branch
3 times, most recently
from
7d1af02 to
23e22c3
Compare
susnux
added
2. developing
skjnldsv
previously approved these changes
May 29, 2025
This comment was marked as outdated.
This comment was marked as outdated.
susnux
force-pushed
the
feat/add-config-for-share-perm
branch
from
23e22c3 to
4201a71
Compare
susnux
added
3. to review
Contributor
Author
Done |
Contributor
Author
|
/compile |
artonge
approved these changes
Jun 4, 2025
susnux
force-pushed
the
feat/add-config-for-share-perm
branch
from
0f3de05 to
35c165e
Compare
Contributor
Author
|
/compile |
come-nc
reviewed
Jun 19, 2025
come-nc
approved these changes
Jun 19, 2025
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
Missing a use for ConfigLexicon I think, but otherwise good 👍
susnux
force-pushed
the
feat/add-config-for-share-perm
branch
from
c0161e9 to
17fa3fc
Compare
Contributor
Author
yes fixed while rebasing |
susnux
force-pushed
the
feat/add-config-for-share-perm
branch
4 times, most recently
from
67f612b to
42a71c7
Compare
…ssions This allows the admin to control the behavior whether link shares with READ permissions should be extended to also gain SHARE permissions, allowing users (public share receivers) to add the share to their cloud. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
susnux
force-pushed
the
feat/add-config-for-share-perm
branch
from
42a71c7 to
1eb6f0b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This allows the admin to control the behavior whether link shares with READ permissions should be extended to also gain SHARE permissions, allowing users (public share receivers) to add the share to their cloud.
Checklist