-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat(dav): allow uploading folders to public shares #52785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c4d99cf to
264ee75
Compare
This comment was marked as resolved.
This comment was marked as resolved.
264ee75 to
edf757f
Compare
00dbedc to
aa41532
Compare
susnux
approved these changes
May 13, 2025
Contributor
susnux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Only found some casing things
fb99a5f to
221d0db
Compare
provokateurin
approved these changes
May 13, 2025
221d0db to
5ddcd85
Compare
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
5ddcd85 to
b286bca
Compare
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
enhancement
feature: dav
feature: files
feature: sharing
🍂 2025-Autumn
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15921
Explanations
Because we cannot give read permissions on a file drop, uploading subfolders is not possible.
Each parent will throw thus preventing to create nested paths. This allowed us to NOT touch the way the normal webdav works and keep things clean.
To circumvent this, we hijack the method in the fileDrop plugin.
Details
Secondary
Also includes the removal of a piece of code that was creating issues in the plugin bootstrapping: aa41532
The
getHTTPMethodsis only here to declare new methods that aren't already handled by the dav server. It is not to conditionally enable or disable a plugin.https://github.com/nextcloud/3rdparty/blob/1a2d791504fcbbe4758e721877c640cd55a7199b/sabre/dav/lib/DAV/Server.php#L506-L530