-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix(files): do not even try to fetch a preview if has-preview is false
#52809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/backport to stable31 |
|
/backport to stable30 |
has-preview is false
susnux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not really expect performance improvements as mimeFallback on the preview endpoint should also check this so so we already would get the mime type icon.
Also one thing to consider is that doing this will stop the browser from caching the mime icon as the preview, so other apps might need to do this as well otherwise we do not save anything 😔
|
This created issues, for some reason I got many img loading errors after this PR. |
This removes one request :) |
This comment was marked as resolved.
This comment was marked as resolved.
d9760e6 to
502e57d
Compare
fixed |
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
502e57d to
37d4bdc
Compare
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Prevent one additional request in case the backend said there was no preview.
This property does NOT mean the preview was not generated, but it actually means we CANNOT generate it (disabled or no preview available)
Good suggestion by @icewind1991 !