Skip to content

Conversation

@come-nc
Copy link
Contributor

@come-nc come-nc commented May 19, 2025

Summary

Given that:

  1. The legacy autoloader is not needed for tests anymore as shown in parent PR chore: Remove useless legacy autoloader for tests #52945
  2. The legacy autoloader is not used for OCA classes as apps folders are never added as a valid root
  3. The legacy autoloader is not used for legacy classes as since Move legacy classes from PSR0 to PSR4 #20265 they do not match the expected naming pattern

I thereby declare it safe to delete the legacy autoloader and rely on sane modern autoloaders like the composer one instead.
Date of death 2025-05-19, after a long period with no brain activity.

I’m a bit sad to say this is not a noticable perf bump according to my testing, but it cannot hurt and opens the door to autoloader optimizing in the future.

Checklist

@come-nc come-nc self-assigned this May 19, 2025
@come-nc come-nc added 3. to review Waiting for reviews technical debt labels May 19, 2025
@come-nc come-nc force-pushed the fix/cleanup-test-legacy-autoloader branch from d96db5c to 9560e00 Compare May 27, 2025 14:16
Base automatically changed from fix/cleanup-test-legacy-autoloader to master May 27, 2025 15:57
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the fix/delete-legacy-autoloader branch from 106be27 to 7c251e4 Compare May 27, 2025 16:06
@come-nc come-nc added this to the Nextcloud 32 milestone May 27, 2025
@come-nc come-nc marked this pull request as ready for review May 27, 2025 16:18
@come-nc come-nc requested a review from a team as a code owner May 27, 2025 16:18
@come-nc come-nc requested review from ChristophWurst, icewind1991, nfebe and skjnldsv and removed request for a team May 27, 2025 16:18
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@susnux susnux merged commit bbfd281 into master Jun 2, 2025
238 of 274 checks passed
@susnux susnux deleted the fix/delete-legacy-autoloader branch June 2, 2025 14:14
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants