-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix: expose via dav capabilities whether calendar app is enabled #53206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
1e0115b to
f113310
Compare
|
/backport to stable31 |
|
I would honestly just create a dedicated list of enabled apps for the logged in user. |
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
f113310 to
bf6b147
Compare
Sounds like a good idea, but for web applications it should be enough to rely on I don't even need this in Talk web page (we have initial state there), it just a bypass for Talk Desktop client to get that data from server capabilities periodically |
I don't think so, apps webroots doesn't mean the user have rights to use that app? 🤔 |
From server/lib/private/Template/JSConfigHelper.php Lines 81 to 93 in 35930a4
I would assume it does? 🤔 Since it checks server/lib/private/App/AppManager.php Lines 207 to 213 in 35930a4
? But a general list would be nice, yea, we have dedicated capabilities in a few apps for that right now. |
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
|
IMHO this does not belong to dav. You can then check if calendar capability is available or not. |
Makes also sense there, but it doesn't have any yet. |
|
Is the capabilities endpoint always specific to a user or is it supposed to be global for the instance? I also see enable app for group as a special case that could be tricky to handle if we mix this up. Otherwise capability or general list of apps for the current user sounds good 👍 |
|
Made an attempt to move it to core capabilities, output is a list of enabled apps. I wonder if there is an issue in exposing this list?
|
If it is the same as on the JS config, then no. In general I think everything in the JS config should be probably a capability to allow using this also in other locations than the webUI (e.g. see Talk desktop or clients etc). |
|
BTW we now also have a OCS api for this in 32 and 31: #53569 |
Not sure this is sufficient from our side, as it would add another API request when people load the talk dashboard? |
Well on webui there is the js config (also as initalstate) and clients need to fetch it anyways. But I still think everything or at least most what is provided as js config should be a capability. |
Summary
Checklist