Skip to content

fix: hide guests group when searching for principals #53369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kesselb merged 2 commits into from
Jun 17, 2025
Merged

fix: hide guests group when searching for principals #53369

kesselb merged 2 commits into from
Jun 17, 2025

Conversation

@kesselb
Copy link
Contributor

@kesselb kesselb commented Jun 6, 2025 •
edited
Loading

Resolves: #52958

Summary

Follow-up for #52914

Checklist

@kesselb kesselb added this to the Nextcloud 32 milestone Jun 6, 2025
@kesselb kesselb self-assigned this Jun 6, 2025
@kesselb kesselb added bug 2. developing Work in progress labels Jun 6, 2025
@kesselb kesselb force-pushed the bug/noid/principal-guest_app-not-found branch 2 times, most recently from f31bb78 to 3e86849 Compare June 10, 2025 15:34
@kesselb kesselb added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 10, 2025
@kesselb kesselb force-pushed the bug/noid/principal-guest_app-not-found branch from 3e86849 to c0e813e Compare June 10, 2025 15:39
@kesselb kesselb marked this pull request as ready for review June 10, 2025 15:44
@kesselb kesselb requested a review from a team as a code owner June 10, 2025 15:44
@kesselb kesselb requested review from icewind1991 and leftybournes and removed request for a team June 10, 2025 15:44
@kesselb kesselb force-pushed the bug/noid/principal-guest_app-not-found branch from c0e813e to 837acdb Compare June 13, 2025 09:49
st3iny
st3iny approved these changes Jun 13, 2025
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kesselb kesselb force-pushed the bug/noid/principal-guest_app-not-found branch from 837acdb to 97059d8 Compare June 15, 2025 13:06
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 16, 2025
@kesselb kesselb force-pushed the bug/noid/principal-guest_app-not-found branch 2 times, most recently from 4bd874f to 3c8ee82 Compare June 16, 2025 13:49
kesselb
kesselb commented Jun 16, 2025
View reviewed changes
build/integration/dav_features/principal-property-search.feature

Scenario: Find a principal by a given displayname
When searching for a principal matching "user0"
Then The search HTTP status code should be "207"
Copy link
Contributor Author

@kesselb kesselb Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I run into conflicts with other behat definitions and therefore use "the search ..." as prefix.

@kesselb
Copy link
Contributor Author

kesselb commented Jun 17, 2025

image

kesselb added 2 commits June 17, 2025 11:19
@kesselb
fix: hide guests group when searching for principals
8b66f35 
Follow-up for #52914

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb
test(dav): add integration test for principal property search
6254354 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb force-pushed the bug/noid/principal-guest_app-not-found branch from 3c8ee82 to 6254354 Compare June 17, 2025 09:19
@kesselb kesselb merged commit 7231883 into master Jun 17, 2025
209 of 216 checks passed
@kesselb kesselb deleted the bug/noid/principal-guest_app-not-found branch June 17, 2025 12:02
@kesselb
Copy link
Contributor Author

kesselb commented Jun 17, 2025

/backport to stable31

@backportbot backportbot bot mentioned this pull request Jun 17, 2025
Merged
@kesselb
Copy link
Contributor Author

kesselb commented Jun 17, 2025

/backport to stable30

@backportbot backportbot bot mentioned this pull request Jun 17, 2025
Merged
2 tasks
nilsding added a commit that referenced this pull request Jul 31, 2025
@nilsding
fix: hide guests group from overall principals
45c8664 
Follow-up for #52914 and #53369

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
@nilsding nilsding mentioned this pull request Jul 31, 2025
Merged
4 tasks
backportbot bot pushed a commit that referenced this pull request Jul 31, 2025
@nilsding @backportbot
fix: hide guests group from overall principals
78495da 
Follow-up for #52914 and #53369

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
backportbot bot pushed a commit that referenced this pull request Jul 31, 2025
@nilsding @backportbot
fix: hide guests group from overall principals
9f7d8ed 
Follow-up for #52914 and #53369

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@st3iny st3iny st3iny approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@SebastianKrupinski SebastianKrupinski Awaiting requested review from SebastianKrupinski

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

Assignees

@kesselb kesselb

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

[Bug]: GroupPrincipalBackend ignores IHideFromCollaborationBackend

5 participants

@kesselb @ChristophWurst @st3iny @skjnldsv