Skip to content

fix(profiler): set default values for fputcsv arguments to avoid depreciation warning #53458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2025
Merged

fix(profiler): set default values for fputcsv arguments to avoid depreciation warning #53458

merged 1 commit into from
Aug 27, 2025

Conversation

@tcitworld
Copy link
Member

@tcitworld tcitworld commented Jun 12, 2025

Avoids flooding logs with

[Thu Jun 12 18:22:25 2025] {"app":"PHP","message":"fputcsv(): the $escape parameter must be provided as its default value will change at server\/lib\/private\/Profiler\/FileProfilerStorage.php#157"}

@tcitworld tcitworld added this to the Nextcloud 32 milestone Jun 12, 2025
@tcitworld tcitworld requested a review from a team as a code owner June 12, 2025 16:23
@tcitworld tcitworld requested review from ArtificialOwl, provokateurin and yemkareems and removed request for a team June 12, 2025 16:23
@tcitworld tcitworld force-pushed the fix-putcsv-default branch from 6e69433 to ba7625f Compare June 16, 2025 15:26
This was referenced Aug 22, 2025
Merged
Merged
ChristophWurst
ChristophWurst approved these changes Aug 27, 2025
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks 👏

nickvergessen
nickvergessen reviewed Aug 27, 2025
View reviewed changes
@tcitworld @nickvergessen
fix(profiler): set default values for fputcsv arguments to avoid depr…
4515974 
…eciation warning

Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld enabled auto-merge August 27, 2025 17:47
@tcitworld tcitworld merged commit 4111bdb into master Aug 27, 2025
213 of 221 checks passed
@tcitworld tcitworld deleted the fix-putcsv-default branch August 27, 2025 18:29
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 28, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems is a code owner automatically assigned from nextcloud/server-backend

@provokateurin provokateurin Awaiting requested review from provokateurin provokateurin is a code owner automatically assigned from nextcloud/server-backend

@st3iny st3iny Awaiting requested review from st3iny

@artonge artonge Awaiting requested review from artonge

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

No one assigned

Labels

3. to review Waiting for reviews developer experience

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

5 participants

@tcitworld @nickvergessen @ChristophWurst @skjnldsv