fix: don't try to get fileid for non exising nodes when serializing events file #53648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
come-nc,
nfebe and
skjnldsv
and removed request for
a team
Member
Author
|
/backport to stable31 |
Member
Author
|
/backport to stable30 |
come-nc
approved these changes
Jun 24, 2025
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
https://docs.nextcloud.com/server/latest/admin_manual/webhook_listeners/index.html#nextcloud-webhook-events should be updated to explain that id may be missing.
come-nc
added
the
pending documentation
icewind1991
force-pushed
the
rename-hooks-webhook
branch
from
e1992e8 to
3df2d05
Compare
skjnldsv
approved these changes
Jun 26, 2025
…vents file Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
rename-hooks-webhook
branch
from
3df2d05 to
ab6f418
Compare
Merged
joshtrichards
added a commit
to nextcloud/documentation
that referenced
this pull request
Nov 11, 2025
Updated the webhook listeners documentation for clarity and consistency, including corrections to event descriptions and examples. Fixes: - nextcloud/server#56371 - nextcloud/server#53648 (review) Signed-off-by: Josh <josh.t.richards@gmail.com>
Member
|
Doc update PR pending in nextcloud/documentation#13853 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes listening to
BeforeNodeRenamedEventandNodeRenamedEventwith webhooks.Fixes #50938