fix(DAV): Clean-up remote + handle application/xml properly #53703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - fix: Handle if service doesn't resolve properly - fix: Return a 503 (rather than 200) if app is not enabled/installed Other than that, some general refactoring. To ease review and for general comparison, compare to `public.php`. Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
bug
3. to review
kesselb
reviewed
Jun 26, 2025
come-nc
reviewed
Jun 30, 2025
remote.php
Outdated
| // All resources served via the DAV endpoint should have the strictest possible | ||
| // policy. Exempted from this is the SabreDAV browser plugin which overwrites | ||
| // this policy with a softer one if debug mode is enabled. | ||
| // NOTE: This breaks HTML styling/templates currently |
Contributor
There was a problem hiding this comment.
We have a ticket for this with some context?
Member
Author
There was a problem hiding this comment.
It's only applicable to some oddball failure scenarios if the templates happened to be used; it's not all that relevant to this particular endpoint (since it's not intended to be used interactively from a browser). But something I noticed while looking at other error handling stuff.
Co-authored-by: Daniel <mail@danielkesselberg.de> Signed-off-by: Josh <josh.t.richards@gmail.com>
Whatever is settled on here will likely get ported to /public.php as well. Signed-off-by: Josh <josh.t.richards@gmail.com>
Endpoints are all hardcoded since 7bdde98 and were formally deprecated within info.xml in nextcloud/appstore#156. Follow-up PR will clean-up references elsewhere. Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
changed the title
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
5 tasks
Signed-off-by: Josh <josh.t.richards@gmail.com>
This was referenced Aug 22, 2025
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 25, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content-Typeapplication/xml(in remote in addition totext/xml)Also:
Other than that, some general refactoring.
To ease review and for general comparison, compare to
public.php.Checklist