Skip to content

Conversation

@icewind1991
Copy link
Member

Allows configuring WebDAV external storage with a space (or other characters that require url encoding) in the "Remote subfolder"

  • Make sure the root we work with isn't urlencoded
  • Encode the general base url

Fixes #52863

@icewind1991 icewind1991 added this to the Nextcloud 32 milestone Jun 30, 2025
@icewind1991 icewind1991 requested a review from a team as a code owner June 30, 2025 15:54
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jun 30, 2025
@icewind1991 icewind1991 removed the request for review from a team June 30, 2025 15:54
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the dav-external-url-encoded-root branch from f52adaa to 6d0119b Compare June 30, 2025 16:01
@icewind1991
Copy link
Member Author

/backport to stable31

@provokateurin
Copy link
Member

@icewind1991 backport to stable30 as well?

@skjnldsv
Copy link
Member

skjnldsv commented Jul 1, 2025

Tests? 🙈

@skjnldsv skjnldsv merged commit 4eee160 into master Aug 1, 2025
273 of 292 checks passed
@skjnldsv skjnldsv deleted the dav-external-url-encoded-root branch August 1, 2025 07:31
@backportbot
Copy link

backportbot bot commented Aug 1, 2025

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/53729/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 6d0119bf

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/53729/stable31

Error: Failed to push branch backport/53729/stable31: fatal: could not read Username for 'https://github.com': No such device or address


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Spaces in remote subfolder of external storage/WebDAV do not work

5 participants