fix: give target file all permissions on copy #53733
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
requested review from
ArtificialOwl,
leftybournes and
yemkareems
and removed request for
a team
icewind1991
added
3. to review
Member
Author
|
Failing tests are due to a check introduced with #41565 needs to be clarified what the correct behavior is. |
4 tasks
5 tasks
8 tasks
susnux
approved these changes
Jul 14, 2025
|
Is there anything blocking this currently? I also ran into this today and would enjoy seeing it fixed very much! Cheers |
This was referenced Sep 4, 2025
Merged
Merged
Merged
This was referenced Sep 25, 2025
Merged
Merged
rotdrop
added a commit
to rotdrop/nextcloud-app-files-archive
that referenced
this pull request
Oct 15, 2025
See - rotdrop/files_archive#55 - nextcloud/server#53726 - nextcloud/server#53733 Nextcloud up to and including version 32 copies the read-only-permissions of a read-only source to the target of a copy operation, even if the destination storage is writable. This should be fixed upstream, as a workaround a forced scan of the destination seems to also fix the problem at the cost of performance, of course.
rotdrop
added a commit
to rotdrop/nextcloud-app-files-archive
that referenced
this pull request
Oct 15, 2025
See - #55 - nextcloud/server#53726 - nextcloud/server#53733 Nextcloud up to and including version 32 copies the read-only-permissions of a read-only source to the target of a copy operation, even if the destination storage is writable. This should be fixed upstream, as a workaround a forced scan of the destination seems to also fix the problem at the cost of performance, of course.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the copy is spiritually a newly created file, the old permissions shouldn't affect it.
Fixes #52779