chore(OC\Share\Constants): Remove unused SHARE_TYPE_* constants #53945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
requested review from
Altahrim,
ArtificialOwl and
leftybournes
and removed request for
a team
provokateurin
added
3. to review
susnux
approved these changes
Jul 22, 2025
salmart-dev
approved these changes
Jul 29, 2025
Contributor
salmart-dev
left a comment
salmart-dev
left a comment
There was a problem hiding this comment.
LGTM!
One of the constants was deprecated in 2021, but I guess this can be ignored.
Member
Author
Anything deprecated can be removed after 9 releases/3 years, so this is fine. |
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
chore/share-constants
branch
from
40b5f52 to
3c7fce3
Compare
Member
Author
|
Rebased to fix Cypress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.