Skip to content

Conversation

@szaimen
Copy link
Contributor

@szaimen szaimen commented Jul 29, 2025

Fix is done as suggested by customer

@szaimen szaimen added this to the Nextcloud 32 milestone Jul 29, 2025
@szaimen szaimen requested a review from a team as a code owner July 29, 2025 09:18
@szaimen szaimen requested review from Altahrim, icewind1991 and sorbaugh and removed request for a team July 29, 2025 09:18
@szaimen szaimen added bug 3. to review Waiting for reviews labels Jul 29, 2025
@szaimen szaimen requested a review from come-nc July 29, 2025 09:18
@szaimen
Copy link
Contributor Author

szaimen commented Jul 29, 2025

/backport to stable31

@szaimen
Copy link
Contributor Author

szaimen commented Jul 29, 2025

/backport to stable30

@szaimen szaimen force-pushed the enh/noid/ensure-correctly-handling-special-characters branch 2 times, most recently from f0ce856 to aaee0a8 Compare July 31, 2025 08:22
…ers are handled correctly

Signed-off-by: Simon L. <szaimen@e.mail.de>
@szaimen szaimen force-pushed the enh/noid/ensure-correctly-handling-special-characters branch from aaee0a8 to 840fba1 Compare August 1, 2025 08:48
@kesselb
Copy link
Collaborator

kesselb commented Aug 1, 2025

Hi, I find that, without additional context, a rather weird change. What problem did the customer run into? Also this pr changes only one write operation. If there's a problem, that non-utf-8-card-data must be sanitized, then it should happen in updateCard and createCard, no?

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. This doesn't seem right.

The job is a one-time migration, no? What about non-UTF-8 data that was already processed by the job? It won't be fixed.

How did non-UTF-8 end up in the cards table if PUTing cards validates for UTF-8 too? Manual inserts?

@ChristophWurst ChristophWurst added the feature: carddav Related to CardDAV internals label Aug 14, 2025
This was referenced Aug 22, 2025
@gaudryc
Copy link

gaudryc commented Aug 29, 2025

Hello,

I'm the customer who originally requested this fix.
I created this fix on Nextcloud 29.0.8 to address the issue #46100.
I tried to reproduce the original issue today without this fix, but without success.
I can confirm that you can ignore this fix since the issue #46100 has been resolved.

Best regards,
Chris

@szaimen
Copy link
Contributor Author

szaimen commented Aug 29, 2025

Hello,

I'm the customer who originally requested this fix. I created this fix on Nextcloud 29.0.8 to address the issue #46100. I tried to reproduce the original issue today without this fix, but without success. I can confirm that you can ignore this fix since the issue #46100 has been resolved.

Best regards, Chris

Great, thank you for the feedback! Closing then :)

@szaimen szaimen closed this Aug 29, 2025
@szaimen szaimen deleted the enh/noid/ensure-correctly-handling-special-characters branch August 29, 2025 10:30
@szaimen szaimen removed this from the Nextcloud 32 milestone Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews backport-request bug feature: carddav Related to CardDAV internals

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants