-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Added parameter to disable web UI integration with local client #54191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
27f49d6 to
97c497a
Compare
97c497a to
e9e9b76
Compare
e9e9b76 to
d0b4449
Compare
d0b4449 to
70ce5be
Compare
|
/compile rebase |
70ce5be to
8f502ae
Compare
This comment was marked as resolved.
This comment was marked as resolved.
ff2ad47 to
af4cfd4
Compare
af4cfd4 to
46efdc4
Compare
|
/compile rebase-amend |
… client Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
46efdc4 to
17d7c7e
Compare
susnux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - one comment
| * | ||
| * Defaults to ``true`` | ||
| */ | ||
| 'web_ui_integration_local_client_enabled' => true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a system config rather than a app config to be set in admin settings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I mean, I didn't think this through, I just revived an old approved PR 🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better as an app config, so that it can be added to UI more easily later.
Manual PR for CI
Closes #50280