Skip to content

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Aug 1, 2025

Manual PR for CI
Closes #50280

@skjnldsv skjnldsv added this to the Nextcloud 32 milestone Aug 1, 2025
@skjnldsv skjnldsv self-assigned this Aug 1, 2025
@skjnldsv skjnldsv added enhancement 4. to release Ready to be released and/or waiting for tests to finish labels Aug 1, 2025
@skjnldsv skjnldsv requested review from a team as code owners August 1, 2025 07:24
@skjnldsv skjnldsv requested review from CarlSchwan, nfebe, sorbaugh and susnux and removed request for a team August 1, 2025 07:24
@skjnldsv skjnldsv force-pushed the master-IB#1156402 branch from 27f49d6 to 97c497a Compare August 1, 2025 07:28
@skjnldsv skjnldsv force-pushed the master-IB#1156402 branch from 97c497a to e9e9b76 Compare August 1, 2025 07:29
@nextcloud-command nextcloud-command requested a review from a team as a code owner August 1, 2025 07:34
@skjnldsv skjnldsv force-pushed the master-IB#1156402 branch from d0b4449 to 70ce5be Compare August 1, 2025 07:50
@skjnldsv
Copy link
Member Author

skjnldsv commented Aug 1, 2025

/compile rebase

@skjnldsv skjnldsv requested a review from nickvergessen August 1, 2025 08:17
@skjnldsv

This comment was marked as resolved.

@skjnldsv
Copy link
Member Author

skjnldsv commented Aug 1, 2025

/compile rebase-amend

pboguslawski and others added 3 commits August 1, 2025 08:47
… client

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - one comment

*
* Defaults to ``true``
*/
'web_ui_integration_local_client_enabled' => true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a system config rather than a app config to be set in admin settings?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I mean, I didn't think this through, I just revived an old approved PR 🙈

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better as an app config, so that it can be added to UI more easily later.

This was referenced Aug 22, 2025
This was referenced Sep 2, 2025
This was referenced Sep 25, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement feature: files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants