fix(files_sharing): use user defined passwords #54399
Conversation
A previous MR(54055) resulted in the NcActionInput component responsible for creating file shares discarding user provided passwords, in favor of the system generated one. This was caused by drift between the component and the underlying Share model, resulting in the component calling .sync on a non-existent attribute, which meant the password was never updated. To reproduce (with password_policy enabled): * Under a files "External Shares", click "Create public link" * Supply a password to the password field, e.g., "testing-password_123" * Click "Create share" * Attempt to navigate to the generated share link and access the shared file with the password you provided at the time of creating the share. * The provided password will be rejected, as it was never updated from the system generated one. Signed-off-by: Darian Culver <darian.culver@catalyst.net.nz>
Darianisak
requested review from
skjnldsv,
susnux and
szaimen
and removed request for
a team
|
/backport to stable31 |
|
/backport to stable30 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
@nfebe :) |
|
/backport to stable32 |
|
/compile |
|
@hamza221 needs to be compiled manually. |
|
I'll create a new Pr @susnux ? |
| class="share-link-password" | ||
| :label="t('files_sharing', 'Enter a password')" | ||
| :value.sync="share.newPassword" | ||
| :value.sync="share.password" |
There was a problem hiding this comment.
This needs to be tested deeply!
I did this so that you can rollback changes if the share update fails.
|
new pr #55026 |
|
fixed in #55073 |
5 participants
Summary
A previous MR(54055) resulted in the NcActionInput component responsible for creating file shares discarding user provided passwords, in favor of the system generated one.
This was caused by drift between the component and the underlying Share model, resulting in the component calling .sync on a non-existent attribute, which meant the password was never updated.
To reproduce (with password_policy enabled):
TODO
N/A
Checklist