fix(systemtags): ensure no invalid color is passed to NcColorPicker
#54516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
CarlSchwan,
artonge,
nfebe,
skjnldsv and
sorbaugh
and removed request for
a team,
nfebe and
sorbaugh
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
skjnldsv
approved these changes
Aug 21, 2025
CarlSchwan
approved these changes
Aug 21, 2025
Member
|
/compile rebase |
Merged
auto-merge was automatically disabled
August 24, 2025 18:00
Pull request was closed
AndyScherzinger
force-pushed
the
fix/systemtags-picker-color
branch
from
395ea7f to
cc3938d
Compare
Member
|
Wem, rebase closed the PR because of zero commits @susnux... Die the commits get merged via another PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prevent passing
#as color - this is not a valid color.So fallback to
#000000as default (which basically is just used on the picker).Checklist