fix(caldav): public calendars are always read-only #54535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
added
3. to review
SebastianKrupinski
approved these changes
Aug 20, 2025
CarlSchwan
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The value of
oc_dav_shares.accessis always 4 (ACCESS_PUBLIC) 1 and can never be 3 (ACCESS_READ) 2 causing read-only to always be set to false.However, we don't support editing public calendars so we should reflect that in the read-only property accordingly.
Checklist
Footnotes
\OCA\DAV\CalDAV\CalDavBackend::ACCESS_PUBLIC↩\OCA\DAV\DAV\Sharing\Backend::ACCESS_READ↩