chore: refactor .htaccess to ease maintenance/future cleanup

[joshtrichards]

Summary

Despite the size this changes should be a no-op in terms of functionality. Just trying to ease future maintenance burden:

• Identified opportunities for future streamlining (dead/unnecessary code) and implementation consistency
• Made it clearer what things are there for + where they fit in with our various endpoints

Added:

• New comments/explanations within the rewrite rules section
• Separated distinct RewriteRules into dedicated sections for ease of maintenance

Changed:

• Distinct indentation for greater visibility of section hierarchy
• Moved the global HTTP_AUTHORIZATION workaround rule to the top (rather than being second)
  • This was the only implementation change, but should be a no-op for all practical purposes

Possible follow-ups:

• Some potential follow-up items (most are marked with XXX in the comments) were discovered while doing this refactor
• The rules used for htaccess.rewritebase should also be audited and possibly restructured in a similar manner:

  • server/lib/private/Setup.php

    Lines 573 to 595 in 93b97f4

    	if ($rewriteBase !== '') {
    	$content .= "\n<IfModule mod_rewrite.c>";
    	$content .= "\n Options -MultiViews";
    	$content .= "\n RewriteRule ^core/js/oc.js$ index.php [PT,E=PATH_INFO:$1]";
    	$content .= "\n RewriteRule ^core/preview.png$ index.php [PT,E=PATH_INFO:$1]";
    	$content .= "\n RewriteCond %{REQUEST_FILENAME} !\\.(css|js|mjs|svg|gif|ico|jpg|jpeg|png|webp|html|otf|ttf|woff2?|map|webm|mp4|mp3|ogg|wav|flac|wasm|tflite)$";
    	$content .= "\n RewriteCond %{REQUEST_FILENAME} !/core/ajax/update\\.php";
    	$content .= "\n RewriteCond %{REQUEST_FILENAME} !/core/img/(favicon\\.ico|manifest\\.json)$";
    	$content .= "\n RewriteCond %{REQUEST_FILENAME} !/(cron|public|remote|status)\\.php";
    	$content .= "\n RewriteCond %{REQUEST_FILENAME} !/ocs/v(1|2)\\.php";
    	$content .= "\n RewriteCond %{REQUEST_FILENAME} !/robots\\.txt";
    	$content .= "\n RewriteCond %{REQUEST_FILENAME} !/(ocs-provider|updater)/";
    	$content .= "\n RewriteCond %{REQUEST_URI} !^/\\.well-known/(acme-challenge|pki-validation)/.*";
    	$content .= "\n RewriteCond %{REQUEST_FILENAME} !/richdocumentscode(_arm64)?/proxy.php$";
    	$content .= "\n RewriteRule . index.php [PT,E=PATH_INFO:$1]";
    	$content .= "\n RewriteBase " . $rewriteBase;
    	$content .= "\n <IfModule mod_env.c>";
    	$content .= "\n SetEnv front_controller_active true";
    	$content .= "\n <IfModule mod_dir.c>";
    	$content .= "\n DirectorySlash off";
    	$content .= "\n </IfModule>";
    	$content .= "\n </IfModule>";
    	$content .= "\n</IfModule>";

• Any future implementation changes may need to be coordinated with:
  • Doc changes for the suggested Nginx configuration
  • AIO? (maybe)
  • Community micro-services Docker image (maybe)

TODO

• ...

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[kesselb]

mbstring.func_overload was removed with php8

[joshtrichards]

#53578 ;-)

[come-nc]

merged, please rebase and fix conflicts here

[szaimen]

• AIO? (maybe)

AIO uses Apache under the hood so no manual changes should not be needed. See https://github.com/nextcloud/all-in-one/blob/main/Containers/apache/nextcloud.conf#L31