fix(settings): adjust colors used by legacy setup checks ui #54621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even if the rule is `background-color` in reality it is the color of the icon thus needs the text color. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
requested review from
nfebe and
skjnldsv
and removed request for
a team
Merged
CarlSchwan
approved these changes
Aug 25, 2025
szaimen
reviewed
Aug 25, 2025
skjnldsv
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Even if the rule is
background-colorin reality it is the color of the icon thus needs the text color.Not that the "hint" above (and on the bottom) now is readable as well as the icon is now visible.
Checklist