-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat(tests): Fail on PHPUnit warnings and risky tests, show deprecations #54905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58e0aa5 to
73cc44d
Compare
f1761d8 to
6aca9f8
Compare
Contributor
Author
|
For s3 tests, we have: There is no easy way to ignore those it seems, apart from using a custom error handler for these tests. |
Contributor
Author
6aca9f8 to
0073f1f
Compare
6 tasks
c8fff61 to
f1d2509
Compare
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Turn data providers into static methods, mostly. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
…icationTest Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
…tests Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
…dlewareTest Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
df0135a to
8107f61
Compare
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
e504e27 to
5e9af71
Compare
susnux
approved these changes
Sep 27, 2025
provokateurin
approved these changes
Sep 27, 2025
Member
provokateurin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
6 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fail on PHPUnit warnings and risky tests, show deprecations.
Checklist