Skip to content

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented Sep 8, 2025

Summary

Before: Node limit is calculated using 1000 * 1000 Bytes (MB).
After: Node limit is calculated correctly using 1024 * 1024 Bytes (MiB).

See also: https://simple.wikipedia.org/wiki/Mebibyte

Checklist

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny added this to the Nextcloud 33 milestone Sep 8, 2025
@st3iny st3iny self-assigned this Sep 8, 2025
@st3iny st3iny requested a review from a team as a code owner September 8, 2025 13:12
@st3iny st3iny added the bug label Sep 8, 2025
@st3iny st3iny requested review from ArtificialOwl and yemkareems and removed request for a team September 8, 2025 13:12
@st3iny st3iny added the 3. to review Waiting for reviews label Sep 8, 2025
@st3iny st3iny requested a review from leftybournes September 8, 2025 13:12
@github-project-automation github-project-automation bot moved this to 🏗️ In progress in 💌 📅 👥 Groupware team Sep 8, 2025
@st3iny
Copy link
Member Author

st3iny commented Sep 8, 2025

/backport to stable32

@st3iny
Copy link
Member Author

st3iny commented Sep 8, 2025

/backport to stable31

@st3iny
Copy link
Member Author

st3iny commented Sep 8, 2025

/backport to stable30

@st3iny st3iny requested a review from solracsf September 8, 2025 13:13
@susnux susnux merged commit 23c2df0 into master Sep 8, 2025
210 of 212 checks passed
@susnux susnux deleted the fix/node-limit-mib branch September 8, 2025 15:58
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Sep 8, 2025
@backportbot
Copy link

backportbot bot commented Sep 8, 2025

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/54951/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 05613984

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/54951/stable30

Error: Failed to push branch backport/54951/stable30: remote: Invalid username or token. Password authentication is not supported for Git operations.
fatal: Authentication failed for 'https://github.com/nextcloud/server.git/'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@st3iny
Copy link
Member Author

st3iny commented Sep 9, 2025

/backport to stable30

@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

5 participants