refactor: remove global md5 and replace other use cases with common depenency #54954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…epenency 1. By replacing `blueimp-md5` with `crypto-browserify` we reduce the dependencies because the latter one is already used by `@nextcloud/upload`. 2. Drop the global `md5` as the changed implementation would need a wrapper, but its also not used anymore and deprecated since Nextcloud 20. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
added
technical debt
♻️ refactor
susnux
requested review from
nfebe,
sorbaugh and
szaimen
and removed request for
a team
susnux
requested review from
artonge and
provokateurin
and removed request for
a team and
nfebe
artonge
approved these changes
Sep 8, 2025
Contributor
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
And now I am wondering where is core/src/jquery/placeholder.js used
Contributor
Author
|
@artonge some jQuery plugin, we can drop that together with jQuery as soon as ldap wizard is migrated :) |
provokateurin
approved these changes
Sep 8, 2025
Member
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
md5documentation#13630Summary
blueimp-md5withcrypto-browserifywe reduce the dependencies because the latter one is already used by@nextcloud/upload.md5as the changed implementation would need a wrapper, but its also not used anymore and deprecated since Nextcloud 20.Checklist