Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix autoloading in LPAP integration tests, resolves #544 #550

Merged
merged 1 commit into from
Jul 25, 2016

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Jul 25, 2016

as discussed, @nickvergessen @rullzer

requires backporting

@blizzz blizzz added bug 3. to review Waiting for reviews labels Jul 25, 2016
@blizzz blizzz added this to the Nextcloud 11.0 milestone Jul 25, 2016
@mention-bot
Copy link

@blizzz, thanks for your PR! By analyzing the annotation information on this pull request, we identified @nickvergessen and @LukasReschke to be potential reviewers


define('CLI_TEST_RUN', true);
require_once __DIR__ . '/../../../../lib/base.php';
require_once __DIR__ . '/setup-scripts/config.php';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing NL?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigh temporary replacement IDE

@nickvergessen
Copy link
Member

👍

@blizzz blizzz force-pushed the ldap-integration-test-autoloader branch from 1b67592 to 686cb59 Compare July 25, 2016 09:06
@MorrisJobke
Copy link
Member

👍

@MorrisJobke MorrisJobke merged commit 88cbde6 into master Jul 25, 2016
@MorrisJobke MorrisJobke deleted the ldap-integration-test-autoloader branch July 25, 2016 10:54
@blizzz
Copy link
Member Author

blizzz commented Jul 25, 2016

@karlitschek we should backport this

@karlitschek
Copy link
Member

yes. please backport

@blizzz
Copy link
Member Author

blizzz commented Jul 26, 2016

Backport to stable10 here: #580
stable9 is not affected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants