chore(settings): Drop unneeded 'json' PHP module check (since PHP 8.0.0) #55063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshtrichards
requested review from
come-nc,
provokateurin and
yemkareems
and removed request for
a team
Removed 'json' module from the list of required PHP modules. It's built-in and not possible to disable at compile time since PHP 8.0.0. Refs: - https://www.php.net/manual/en/json.installation.php - https://wiki.php.net/rfc/always_enable_json - https://www.php.net/ChangeLog-8.php#8.0.0 Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
force-pushed
the
jtr/chore/setupcheck-php-json-drop
branch
from
f52f37e to
34f1d52
Compare
provokateurin
approved these changes
Sep 11, 2025
kesselb
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removed
jsonmodule from the list of required PHP modules.It's built-in and not possible to disable at compile time since PHP 8.0.0.
Refs:
Related: nextcloud/documentation#13660
TODO
Checklist