Skip to content

Port away from IQueryBuilder::execute in apps/ #55085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kesselb merged 2 commits into from
Sep 16, 2025
Merged

Port away from IQueryBuilder::execute in apps/ #55085

kesselb merged 2 commits into from
Sep 16, 2025

Conversation

@CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Sep 12, 2025 •
edited by ChristophWurst
Loading

Summary

Second and final part of #54664

Checklist

@CarlSchwan CarlSchwan force-pushed the carl/execute-apps branch 3 times, most recently from bca51cc to c60e325 Compare September 15, 2025 12:19
@CarlSchwan CarlSchwan marked this pull request as ready for review September 15, 2025 12:19
@CarlSchwan CarlSchwan requested review from icewind1991, salmart-dev and sorbaugh and removed request for a team September 15, 2025 12:19
nickvergessen
nickvergessen reviewed Sep 15, 2025
View reviewed changes
come-nc
come-nc requested changes Sep 15, 2025
View reviewed changes
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) technical debt labels Sep 16, 2025
@st3iny
Copy link
Member

st3iny commented Sep 16, 2025

@CarlSchwan Conflicts need to be addressed.

@CarlSchwan
refactor: Port away from IQueryBuilder::execute in apps/
7e1c49a 
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
@CarlSchwan
refactor: Port External\Manager to the query builder
8555f98 
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
@kesselb kesselb disabled auto-merge September 16, 2025 10:11
@kesselb kesselb merged commit 7a2e251 into master Sep 16, 2025
199 of 201 checks passed
@kesselb kesselb deleted the carl/execute-apps branch September 16, 2025 10:11
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 6, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@come-nc come-nc come-nc approved these changes

@blizzz blizzz Awaiting requested review from blizzz blizzz is a code owner

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

@miaulalala miaulalala Awaiting requested review from miaulalala miaulalala is a code owner

@st3iny st3iny Awaiting requested review from st3iny

@SebastianKrupinski SebastianKrupinski Awaiting requested review from SebastianKrupinski SebastianKrupinski is a code owner

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) technical debt

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@CarlSchwan @st3iny @nickvergessen @come-nc @ChristophWurst @kesselb