Skip to content

refactor: Port away from changeColumn #55086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 1 commit into from
Sep 15, 2025
Merged

refactor: Port away from changeColumn #55086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/dav/lib/Migration/Version1004Date20170825134824.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ public function changeSchema(IOutput $output, \Closure $schemaClosure, array $op
$table->addUniqueIndex(['principaluri', 'uri'], 'calendars_index');
} else {
$table = $schema->getTable('calendars');
$table->changeColumn('components', [
$table->modifyColumn('components', [
'notnull' => false,
'length' => 64,
]);
Expand Down Expand Up @@ -324,7 +324,7 @@ public function changeSchema(IOutput $output, \Closure $schemaClosure, array $op
$table->addUniqueIndex(['principaluri', 'uri'], 'calsub_index');
} else {
$table = $schema->getTable('calendarsubscriptions');
$table->changeColumn('lastmodified', [
$table->modifyColumn('lastmodified', [
'notnull' => false,
'unsigned' => true,
]);
Expand Down
2 changes: 1 addition & 1 deletion apps/files_external/lib/Migration/Version1011Date20200630192246.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ public function changeSchema(IOutput $output, Closure $schemaClosure, array $opt
$table->addUniqueIndex(['mount_id', 'key'], 'config_mount_key');
} else {
$table = $schema->getTable('external_config');
$table->changeColumn('value', [
$table->modifyColumn('value', [
'notnull' => false,
'length' => 4000,
]);
Expand Down
2 changes: 1 addition & 1 deletion apps/workflowengine/lib/Migration/Version2200Date20210805101925.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public function changeSchema(IOutput $output, Closure $schemaClosure, array $opt

if ($schema->hasTable('flow_operations')) {
$table = $schema->getTable('flow_operations');
$table->changeColumn('name', [
$table->modifyColumn('name', [
'notnull' => false,
]);
}
Expand Down
25 changes: 0 additions & 25 deletions build/psalm-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,12 +916,6 @@
<code><![CDATA[execute]]></code>
</DeprecatedMethod>
</file>
<file src="apps/dav/lib/Migration/Version1004Date20170825134824.php">
<DeprecatedMethod>
<code><![CDATA[changeColumn]]></code>
<code><![CDATA[changeColumn]]></code>
</DeprecatedMethod>
</file>
<file src="apps/dav/lib/Migration/Version1008Date20181105104826.php">
<DeprecatedMethod>
<code><![CDATA[execute]]></code>
Expand Down Expand Up @@ -1482,11 +1476,6 @@
<code><![CDATA[login]]></code>
</InvalidReturnType>
</file>
<file src="apps/files_external/lib/Migration/Version1011Date20200630192246.php">
<DeprecatedMethod>
<code><![CDATA[changeColumn]]></code>
</DeprecatedMethod>
</file>
<file src="apps/files_external/lib/Migration/Version1015Date20211104103506.php">
<DeprecatedMethod>
<code><![CDATA[execute]]></code>
Expand Down Expand Up @@ -2813,11 +2802,6 @@
<code><![CDATA[bool]]></code>
</InvalidReturnType>
</file>
<file src="apps/workflowengine/lib/Migration/Version2200Date20210805101925.php">
<DeprecatedMethod>
<code><![CDATA[changeColumn]]></code>
</DeprecatedMethod>
</file>
<file src="apps/workflowengine/lib/Service/Logger.php">
<DeprecatedMethod>
<code><![CDATA[getAppValue]]></code>
Expand Down Expand Up @@ -3234,15 +3218,6 @@
<code><![CDATA[execute]]></code>
</DeprecatedMethod>
</file>
<file src="core/Migrations/Version21000Date20201120141228.php">
<DeprecatedMethod>
<code><![CDATA[changeColumn]]></code>
<code><![CDATA[changeColumn]]></code>
<code><![CDATA[changeColumn]]></code>
<code><![CDATA[changeColumn]]></code>
<code><![CDATA[changeColumn]]></code>
</DeprecatedMethod>
</file>
<file src="core/Service/LoginFlowV2Service.php">
<DeprecatedClass>
<code><![CDATA[IToken::DO_NOT_REMEMBER]]></code>
Expand Down
10 changes: 5 additions & 5 deletions core/Migrations/Version21000Date20201120141228.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,16 @@ public function changeSchema(IOutput $output, Closure $schemaClosure, array $opt
if ($loginNameColumn->getLength() !== 255) {
$loginNameColumn->setLength(255);
}
$table->changeColumn('type', [
$table->modifyColumn('type', [
'notnull' => false,
]);
$table->changeColumn('remember', [
$table->modifyColumn('remember', [
'notnull' => false,
]);
$table->changeColumn('last_activity', [
$table->modifyColumn('last_activity', [
'notnull' => false,
]);
$table->changeColumn('last_check', [
$table->modifyColumn('last_check', [
'notnull' => false,
]);
}
Expand All @@ -51,7 +51,7 @@ public function changeSchema(IOutput $output, Closure $schemaClosure, array $opt

if ($schema->hasTable('jobs')) {
$table = $schema->getTable('jobs');
$table->changeColumn('execution_duration', [
$table->modifyColumn('execution_duration', [
'notnull' => false,
'default' => 0,
]);
Expand Down
Loading