Skip to content

Conversation

@SebastianKrupinski
Copy link
Contributor

@SebastianKrupinski SebastianKrupinski commented Sep 22, 2025

Summary

Checklist

Comment on lines 45 to 49
[
'privilege' => '{DAV:}unbind',
'principal' => $this->getOwner(),
'protected' => true,
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[
'privilege' => '{DAV:}unbind',
'principal' => $this->getOwner(),
'protected' => true,
],

Unbind is ignored for resources that are not collections.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Removed

'protected' => true,
],
[
'privilege' => '{DAV:}unbind',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for my understanding, why is the unbind ACL granted for the collection but not the card? doesn't that mean the collection is allowed to be deleted? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I thought the same thing at first the ACL's should technically be on the Object, not the collection, but SabreDAV ignores the ACL on the Object. (Dose not send them) So in the context of Address books, unbind on the collection means "Delete an object", I'm guessing this is because it's a flat list instead of a collection/object tree. I can look more in to it, if you want.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski SebastianKrupinski force-pushed the fix/issue-55169-delete-recent-contact branch from fbf0456 to bb78130 Compare September 24, 2025 11:22
@SebastianKrupinski
Copy link
Contributor Author

@ChristophWurst I was thinking this should be back ported to at least 31?

@ChristophWurst
Copy link
Member

It's a feature and there is currently no requirement to have this in 32. Don't backport

@kesselb kesselb merged commit 4e57136 into master Sep 24, 2025
194 of 198 checks passed
@kesselb kesselb deleted the fix/issue-55169-delete-recent-contact branch September 24, 2025 13:05
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Sep 24, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement

Projects

Development

Successfully merging this pull request may close these issues.

Not possible to clear "Recently contacted" or delete contacts within it

5 participants