-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat: delete recent contact #55247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: delete recent contact #55247
Conversation
afbdf07 to
13d96ed
Compare
| [ | ||
| 'privilege' => '{DAV:}unbind', | ||
| 'principal' => $this->getOwner(), | ||
| 'protected' => true, | ||
| ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| [ | |
| 'privilege' => '{DAV:}unbind', | |
| 'principal' => $this->getOwner(), | |
| 'protected' => true, | |
| ], |
Unbind is ignored for resources that are not collections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Removed
| 'protected' => true, | ||
| ], | ||
| [ | ||
| 'privilege' => '{DAV:}unbind', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for my understanding, why is the unbind ACL granted for the collection but not the card? doesn't that mean the collection is allowed to be deleted? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I thought the same thing at first the ACL's should technically be on the Object, not the collection, but SabreDAV ignores the ACL on the Object. (Dose not send them) So in the context of Address books, unbind on the collection means "Delete an object", I'm guessing this is because it's a flat list instead of a collection/object tree. I can look more in to it, if you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
fbf0456 to
bb78130
Compare
|
@ChristophWurst I was thinking this should be back ported to at least 31? |
|
It's a feature and there is currently no requirement to have this in 32. Don't backport |
Summary
Checklist
3. to review, feature component)stable32)