fix(admin): Hide empty section for users admin delegation #55261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
added
2. developing
come-nc
requested review from
a team,
JuliaKirschenheuter,
julien-nc and
sorbaugh
as code owners
come-nc
requested review from
CarlSchwan and
nfebe
and removed request for
a team
artonge
reviewed
Sep 23, 2025
come-nc
force-pushed
the
fix/hide-empty-settings-section
branch
2 times, most recently
from
02f42df to
4554c89
Compare
provokateurin
approved these changes
Sep 28, 2025
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Adds a new type of settings, delegation, which is only used for admin delegation but does not appear in admin menu. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
… section Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Also renamed delegation into admin-delegation in xml schema. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/hide-empty-settings-section
branch
from
4554c89 to
20e5368
Compare
CarlSchwan
approved these changes
Sep 28, 2025
come-nc
added
the
pending documentation
Member
|
I guess the xsd in the appstore (used for validation) is maintained independently. It's currently out-of-sync with the one in server: |
vitormattos
added a commit
to vitormattos/guests
that referenced
this pull request
Sep 30, 2025
Fallback of: - nextcloud/server#55261 Fixed: PHP Fatal error: Class OCA\Guests\FilteredSettingsManager contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (OCP\Settings\IManager::getAdminDelegatedSettings) in /var/www/html/apps-extra/guests/lib/FilteredSettingsManager.php on line 14 Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When delegating users to a group, these delegated admins see an empty "Admin delegation" section in the settings.
To fix this, I had to add a new type of settings,
delegation. Unlikeadminandpersonal, these settings do not appear in any menu but can still be used for admin delegation.I did not add a new section type, because it works just fine to reuse admin sections for delegated settings. It can be added later if needed.
Checklist
3. to review, feature component)stable32)