-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix: added 3 new light images for facebook, bluesky and mastodon #55269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added 3 new light images for facebook, bluesky and mastodon #55269
Conversation
…them in REUSE.toml Signed-off-by: yemkareems <yemkareems@gmail.com>
susnux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other icons are not really "dark" icons but no color icons.
IMHO here all official logos then should be used also for e.g. X and then also directly used in the settings page.
|
I agree with @susnux - we can just use the colored ones in both cases - also given due to the fact that i.e. facebook only allows for this specific one, no matter dark or light theming. |
…ed on isDarkTheme flag Signed-off-by: yemkareems <yemkareems@gmail.com>
|
Added two new images for x dark and light and switched them based on isDarkTheme flag. |
Signed-off-by: yemkareems <yemkareems@gmail.com>
|
/backport to stable32 |
|
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/55269/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 59609024 33cd89db a3e8f00f
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55269/stable32Error: Failed to clone repository: Failed to clone and cache repo: EACCES: permission denied, mkdir '/app/cache/nextcloud/server' Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |


fix: added 3 new light images for facebook, bluesky and mastodon and added them in REUSE.toml
Summary
TODO
Checklist
3. to review, feature component)stable32)