Improve connectivity check #55321
Merged
Improve connectivity check #55321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
…redirection Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Collaborator
Altahrim
approved these changes
Sep 26, 2025
Altahrim
added
the
pending documentation
Collaborator
joshtrichards
approved these changes
Sep 26, 2025
Member
joshtrichards
left a comment
joshtrichards
left a comment
There was a problem hiding this comment.
Good call.
Maybe add the shuffle just for kicks.
Kind of tempting to put something like https://one.one.one.one/ and/or https://www.speedtest.net/ in here...
| 'https://connectivity.nextcloud.com', 'https://www.eff.org', 'https://edri.org' | ||
| ]); | ||
|
|
||
| foreach ($siteArray as $site) { |
Member
There was a problem hiding this comment.
Suggested change
| foreach ($siteArray as $site) { | |
| shuffle($siteArray); | |
| foreach ($siteArray as $site) { |
Contributor
Author
There was a problem hiding this comment.
No, we prefer to default to the same one always and avoid random behavior.
Member
|
Might be worth backporting this. It's a quasi-bug fix. It's not really a feature exactly. |
Contributor
Author
|
Documented in nextcloud/documentation#13719 Anyone in a hurry can just set connectivity.nextcloud.com in the config file at connectivity_check_domains. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Current version does a GET on our website, which is heavier than needed, both for our website and the Nextcloud instances.
Changed to a dedicated service and a HEAD request.
Also took the opportunity to remove startpage and correct edri url to avoid a redirection.
Checklist
3. to review, feature component)stable32)