Skip to content

refactor: Run rector #55360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
provokateurin merged 3 commits into from
Sep 28, 2025
Merged

refactor: Run rector #55360

provokateurin merged 3 commits into from
Sep 28, 2025

Conversation

@provokateurin
Copy link
Member

@provokateurin provokateurin commented Sep 27, 2025

🧹

@provokateurin provokateurin added this to the Nextcloud 33 milestone Sep 27, 2025
@provokateurin provokateurin added the 3. to review Waiting for reviews label Sep 27, 2025
@provokateurin provokateurin requested review from a team and tcitworld as code owners September 27, 2025 16:37
@provokateurin provokateurin requested review from ArtificialOwl, leftybournes and yemkareems and removed request for a team September 27, 2025 16:37
@provokateurin
refactor: Run rector
6a12fbc 
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 27, 2025
@provokateurin provokateurin marked this pull request as draft September 27, 2025 17:01
@provokateurin provokateurin marked this pull request as ready for review September 27, 2025 18:26
@susnux susnux added 3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) and removed 2. developing Work in progress labels Sep 27, 2025
come-nc
come-nc reviewed Sep 28, 2025
View reviewed changes
come-nc
come-nc reviewed Sep 28, 2025
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like a comment somewhere explaining why the test files are excluded

@provokateurin
refactor: Apply rector Nextcloud 26 set
d59338b 
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin
refactor: Apply rector Nextcloud 27 set
504eae6 
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin merged commit 81d0c73 into master Sep 28, 2025
211 of 215 checks passed
@provokateurin provokateurin deleted the refactor/rector branch September 28, 2025 10:28
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 6, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@come-nc come-nc come-nc approved these changes

@st3iny st3iny Awaiting requested review from st3iny

@SebastianKrupinski SebastianKrupinski Awaiting requested review from SebastianKrupinski SebastianKrupinski is a code owner

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) technical debt

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

4 participants

@provokateurin @susnux @come-nc