fix: Delete legacy OC_Response #55387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
requested review from
ArtificialOwl and
provokateurin
and removed request for
a team
susnux
added
technical debt
pending documentation
susnux
approved these changes
Sep 28, 2025
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Removal should be part of developer docs for removed API
Moved the last used method in base.php where it’s called. Ideally we would remove it but it’s not clear whether that would be possible any time soon or even at all. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/remove-legacy-oc-response
branch
from
70795b0 to
eb54143
Compare
provokateurin
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moved the last used method in base.php where it’s called. Ideally we would remove it but it’s not clear whether that would be possible any time soon or even at all.
Checklist
3. to review, feature component)stable32)