Skip to content

refactor: Port dashboard app to IAppConfig #55396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
come-nc merged 1 commit into from
Oct 1, 2025
Merged

refactor: Port dashboard app to IAppConfig #55396

come-nc merged 1 commit into from
Oct 1, 2025

Conversation

@CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Sep 29, 2025

Checklist

@CarlSchwan
refactor: Port dashboard app to IAppConfig
76736cf 
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
@CarlSchwan CarlSchwan added this to the Nextcloud 33 milestone Sep 29, 2025
@CarlSchwan CarlSchwan self-assigned this Sep 29, 2025
@CarlSchwan CarlSchwan added 3. to review Waiting for reviews technical debt ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Sep 29, 2025
@CarlSchwan CarlSchwan marked this pull request as ready for review September 29, 2025 09:15
@CarlSchwan CarlSchwan requested a review from a team as a code owner September 29, 2025 09:15
@CarlSchwan CarlSchwan requested review from Altahrim, ArtificialOwl and yemkareems and removed request for a team September 29, 2025 09:15
@ArtificialOwl
Copy link
Member

ArtificialOwl commented Sep 30, 2025

you could also add a lexicon config file,
If you want to use getAppValueArray(), I would use a new config key and mark the previous one as deprecated

@come-nc come-nc merged commit d36fc65 into master Oct 1, 2025
244 of 253 checks passed
@come-nc come-nc deleted the carl/dashboard-appconfig branch October 1, 2025 09:11
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 6, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArtificialOwl ArtificialOwl ArtificialOwl approved these changes

@come-nc come-nc come-nc approved these changes

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems is a code owner automatically assigned from nextcloud/server-backend

Assignees

@CarlSchwan CarlSchwan

Labels

3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) technical debt

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

4 participants

@CarlSchwan @ArtificialOwl @come-nc