Skip to content

test: migrate LoginForm component test to vitest #55442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
susnux merged 2 commits into from
Oct 6, 2025
Merged

test: migrate LoginForm component test to vitest #55442

susnux merged 2 commits into from
Oct 6, 2025

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Sep 30, 2025 •
edited
Loading

Summary

Cypress has some limitations:

  • its vue 2 supported was removed
  • it fails with our vue 3 migration due to 2 different vue versions being present
  • its slow compared to vitest

Checklist

@susnux susnux added this to the Nextcloud 33 milestone Sep 30, 2025
@susnux susnux requested a review from a team as a code owner September 30, 2025 21:04
@susnux susnux added the 3. to review Waiting for reviews label Sep 30, 2025
@susnux susnux requested a review from a team as a code owner September 30, 2025 21:04
@susnux susnux added tests Related to tests ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Sep 30, 2025
@susnux susnux requested review from CarlSchwan, artonge, nfebe, skjnldsv and szaimen and removed request for a team September 30, 2025 21:04
@susnux susnux force-pushed the refactor/migrate-cypress-tests branch from d3229c6 to 8626912 Compare October 6, 2025 13:08
susnux added 2 commits October 6, 2025 15:18
@susnux
test: migrate LoginForm component test to vitest
ba01412 
Cypress has some limitations:
- its vue 2 supported was removed
- it fails with our vue 3 migration due to 2 different vue versions
  being present
- its slow compared to vitest

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: compile assets
62539ec 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the refactor/migrate-cypress-tests branch from 8626912 to 62539ec Compare October 6, 2025 13:20
@susnux susnux requested a review from a team as a code owner October 6, 2025 13:20
@susnux susnux requested review from come-nc and yemkareems and removed request for a team October 6, 2025 13:20
@susnux susnux merged commit cb1a6f7 into master Oct 6, 2025
200 of 206 checks passed
@susnux susnux deleted the refactor/migrate-cypress-tests branch October 6, 2025 15:41
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 6, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nfebe nfebe nfebe approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner automatically assigned from nextcloud/server-frontend

@szaimen szaimen Awaiting requested review from szaimen szaimen is a code owner automatically assigned from nextcloud/server-frontend

@artonge artonge Awaiting requested review from artonge

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems was automatically assigned from nextcloud/server-backend

@come-nc come-nc Awaiting requested review from come-nc come-nc was automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) tests Related to tests

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

4 participants

@susnux @nfebe @CarlSchwan