refactor: Port away from search #55482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
provokateurin
approved these changes
Oct 1, 2025
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Hehe ok I should have done that right away 🙈
Member
|
Does it really makes sense for console autocompletions to go from uid to display name? |
Member
Author
It search for both uid and display names but the completion result is still the uid. I think it makes sense particularly when using the ldap/saml/openid backends where the uid is not a user friendly string but an UUID |
CarlSchwan
requested review from
a team,
ChristophWurst,
miaulalala,
nickvergessen and
st3iny
as code owners
CarlSchwan
requested review from
Altahrim,
nfebe and
salmart-dev
and removed request for
a team
come-nc
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
3. to review, feature component)stable32)