-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat: add occ command to scan and delete orphaned keys #55556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as spam.
This comment was marked as spam.
come-nc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to use Node API intead of View.
Also it feels you took inspiration from EncryptAll which since got cleaned up: #55472
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
9f3d73b to
f1cdf68
Compare
|
/backport to stable30 |
|
/backport to stable31 |
|
/backport! to stable30 |
|
/backport to stable32 |
come-nc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to allow either printing/deleting on the go or limit to some users to avoid having to run on all the users in one go, which on some big instances will be an issue, but this can be improved in follow-ups, we should merge this as a first version.
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/55556/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick f1cdf688
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55556/stable30Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/55556/stable30."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
tracked here #56349 |
Summary
As an administrator I want to be able to delete encryption Keys that are orphaned ( the encrypted file was deleted without the corresponding key)
encryption:clean-orphaned-keysscans all users' filesytems for default module encryption Keys and lists them with possibility to delete all of them or specific onesTODO
Checklist
3. to review, feature component)stable32)