Skip to content

refactor: use IEmailValidator.isValid instead of IMailer.validateEmailAddress #55557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kesselb merged 1 commit into from
Oct 7, 2025
Merged

refactor: use IEmailValidator.isValid instead of IMailer.validateEmailAddress #55557

kesselb merged 1 commit into from
Oct 7, 2025

Conversation

@kesselb
Copy link
Contributor

@kesselb kesselb commented Oct 4, 2025 •
edited
Loading

Summary

Follow up for #53834 to use the new IEmailValidator.isValid method.

Checklist

@kesselb kesselb added this to the Nextcloud 33 milestone Oct 4, 2025
@kesselb kesselb self-assigned this Oct 4, 2025
@kesselb kesselb added 3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Oct 4, 2025
@kesselb kesselb requested review from ArtificialOwl, come-nc and yemkareems and removed request for a team October 4, 2025 18:51
@mrsakrano

This comment was marked as spam.

Sign in to view
@kesselb
refactor: use IEmailValidator.isValid instead of IMailer.validateEmai…
83a6917 
…lAddress

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb force-pushed the refactor/use-iemailaddressvalidator branch from c3959b0 to 83a6917 Compare October 4, 2025 19:54
@st3iny st3iny enabled auto-merge October 7, 2025 11:32
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 7, 2025
@kesselb kesselb disabled auto-merge October 7, 2025 17:15
@kesselb kesselb merged commit db3e845 into master Oct 7, 2025
275 of 289 checks passed
@kesselb kesselb deleted the refactor/use-iemailaddressvalidator branch October 7, 2025 17:15
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 6, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@st3iny st3iny st3iny approved these changes

@come-nc come-nc come-nc approved these changes

@SebastianKrupinski SebastianKrupinski SebastianKrupinski approved these changes

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems is a code owner automatically assigned from nextcloud/server-backend

Assignees

@kesselb kesselb

Labels

4. to release Ready to be released and/or waiting for tests to finish ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

6 participants

@kesselb @mrsakrano @st3iny @come-nc @SebastianKrupinski