Skip to content

Conversation

@SystemKeeper
Copy link
Contributor

@SystemKeeper SystemKeeper commented Oct 13, 2025

Summary

When executing 32bit tests we observe some sideffects as we remove all files from the data directory at

protected static function tearDownAfterClassCleanStrayDataFiles($dataDir) {
$knownEntries = [
'nextcloud.log' => true,
'audit.log' => true,
'owncloud.db' => true,
'.ocdata' => true,
'..' => true,
'.' => true,
];
if ($dh = opendir($dataDir)) {
while (($file = readdir($dh)) !== false) {
if (!isset($knownEntries[$file])) {
self::tearDownAfterClassCleanStrayDataUnlinkDir($dataDir . '/' . $file);
}
}
closedir($dh);
}
}

which includes appdata directory. Since we only check once if the appdata folder exists, following runs might fail, when the classes are retained. Therefore we specifically unset some classes to ensure the tests run through.

Test-Run: https://github.com/nextcloud/server/actions/runs/18461056236/job/52592428489

Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper SystemKeeper requested a review from a team as a code owner October 13, 2025 10:03
@SystemKeeper SystemKeeper requested review from Altahrim and removed request for a team October 13, 2025 10:03
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💙

@SystemKeeper SystemKeeper merged commit 4c5d1a2 into master Oct 13, 2025
218 of 225 checks passed
@SystemKeeper SystemKeeper deleted the fix/noid/fix-32bit-test-runs branch October 13, 2025 10:53
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants