fix(preview-cleanup): Also delete previews stored in the oc_previews table #55738
+66
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
requested review from
icewind1991,
leftybournes and
nfebe
and removed request for
a team
CarlSchwan
force-pushed
the
carl/cleanup-preview-command
branch
from
0250479 to
9ecdd6d
Compare
salmart-dev
reviewed
Oct 30, 2025
| private readonly StorageFactory $storageFactory, | ||
| private readonly PreviewMapper $previewMapper, | ||
| private readonly IDBConnection $connection, | ||
| private readonly LoggerInterface $logger, |
Contributor
There was a problem hiding this comment.
Seems this is an unused leftover
salmart-dev
approved these changes
Oct 30, 2025
Contributor
salmart-dev
left a comment
salmart-dev
left a comment
There was a problem hiding this comment.
Just a tiny comment for a leftover.
Not sure about the transaction question: right now we don't use transactions, right?
come-nc
approved these changes
Nov 3, 2025
…table Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
CarlSchwan
force-pushed
the
carl/cleanup-preview-command
branch
from
9ecdd6d to
247b66c
Compare
Member
Author
Yeah, something we might want to reconsider. But for later :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
3. to review, feature component)stable32)