feat(TaskProcessing): Introduce ITriggerableProvider #55741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelklehr
requested review from
Altahrim,
CarlSchwan and
provokateurin
and removed request for
a team
kyteinsky
reviewed
Oct 16, 2025
marcelklehr
force-pushed
the
feat/taskprocessing-trigger-aware-provider
branch
from
4fc76fe to
d04af80
Compare
oleksandr-nc
approved these changes
Oct 20, 2025
Contributor
oleksandr-nc
left a comment
oleksandr-nc
left a comment
There was a problem hiding this comment.
Can we add some context to the logs, like to both new error logs to include at least taskTypeId and (if available) the provider id?
Can we split try-catch block? Currently if trigger call will raise exception it can print Failed to check DB for running tasks after a task was scheduled for a triggerable provider. Not triggering the provider. which will be misleading, imho.
Member
Author
Only if trigger() throws an OCP\Db\Exception, which is unlikely, but I'm happy to split it. |
Signed-off-by: Marcel Klehr <mklehr@gmx.net> # Conflicts: # lib/private/TaskProcessing/Db/TaskMapper.php
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
marcelklehr
force-pushed
the
feat/taskprocessing-trigger-aware-provider
branch
from
7bb6f23 to
7f15598
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is part of a larger project to reduce the polling pressure on the server from ex apps. This PR introduces Triggerable Providers which will usually be ex app providers. Once a new task becomes available while no other task is running, this will call the trigger method on the provider to nudge it to ask for more tasks.
Checklist
3. to review, feature component)stable32)