fix(trashbin): make sure the trashed files are deleted if we don't have any available space left #55742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve any available space left Logic taken from the files_versions expiration. It seems the second argument from the isExpired method wasn't even used anywhere. Signed-off-by: Thomas Citharel <tcit@tcit.fr>
…bin::expire static method Instead of handling everything itself, and so that the available space is considered in deleting trashed files even if not expired yet. Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld
requested review from
ArtificialOwl,
sorbaugh and
yemkareems
and removed request for
a team
CarlSchwan
approved these changes
Oct 16, 2025
come-nc
approved these changes
Oct 20, 2025
Member
Author
|
Is this backport worthy? |
6 tasks
artonge
added a commit
that referenced
this pull request
Oct 23, 2025
…hange Revert trashbin expiration handling in #55742
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Logic taken from the
files_versionsexpiration.It seems the second argument from the
isExpiredmethod wasn't even used anywhere, so I think theautopolicy depending on free available storage doesn't work at all.Note that on cases without any user quota set, files will only be deleted when the actual available space is 0 or less.
Checklist
3. to review, feature component)stable32)