-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
refactor(test): migrate Cypress component test to vitest #55747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
8a4a65b to
e7357df
Compare
szaimen
approved these changes
Oct 14, 2025
Contributor
szaimen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
susnux
commented
Oct 14, 2025
|
|
||
| <!-- Database type select --> | ||
| <fieldset class="setup-form__database-type"> | ||
| <legend class="hidden-visually"> |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just for your information this is also somewhat of an a11y fix as per WCAG every fieldset (role group) must have a label by using a legend.
artonge
approved these changes
Oct 15, 2025
CarlSchwan
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2. developing
Work in progress
♻️ refactor
Refactor code (not a bug fix, not a feature just refactoring)
tests
Related to tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reasons for this:
@nextcloud/dialogsor@nextcloud/password-confirmationwhich are already using Vue 3.Other benefits: We can mock whatever we want because its now more like normal unit tests.
So its also a bit easier to test composables etc and only have to think about one way of writing your frontend unit tests located next to your source code.
For real browser tests we have end2end tests which are still Cypress :)
Checklist
3. to review, feature component)stable32)