Skip to content

fix(ocm-sharing): The owner needs to be set for sharing to work #55827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2025
Merged

fix(ocm-sharing): The owner needs to be set for sharing to work #55827

merged 1 commit into from
Oct 22, 2025

Conversation

@mickenordin
Copy link
Contributor

@mickenordin mickenordin commented Oct 17, 2025 •
edited
Loading

The specification says that the display name is optional and can thus be empty, and in fact it is from oCIS and CERNBox shares.

The correct thing to set is the required opaque id from the remote provider, the owner which will always be there.

Moved here from #55752

@mickenordin mickenordin requested a review from a team as a code owner October 17, 2025 11:46
@mickenordin mickenordin requested review from sorbaugh and removed request for a team October 17, 2025 11:46
@mickenordin
Copy link
Contributor Author

mickenordin commented Oct 17, 2025

/backport to stable32

@mickenordin mickenordin force-pushed the fix/ocm-owner-sharing branch from 8030a9d to 7335dd0 Compare October 17, 2025 14:49
@mickenordin mickenordin force-pushed the fix/ocm-owner-sharing branch from 7335dd0 to 8cf1753 Compare October 21, 2025 14:05
@mickenordin mickenordin added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 21, 2025
@mickenordin
fix(ocm-sharing): The owner needs to be set for sharing to work
f7dcd1d 
The specification says that the display name is optional and can thus
be empty, and in fact it is from oCIS and CERNBox shares.

The correct thing to set is the required opaque id from the remote
provider, the `owner` which will allways be there.

Signed-off-by: Micke Nordin <kano@sunet.se>
@mickenordin mickenordin force-pushed the fix/ocm-owner-sharing branch from 6b07b1a to f7dcd1d Compare October 22, 2025 06:54
@nickvergessen nickvergessen merged commit 00a6a73 into master Oct 22, 2025
187 checks passed
@nickvergessen nickvergessen deleted the fix/ocm-owner-sharing branch October 22, 2025 08:26
@nickvergessen
Copy link
Member

nickvergessen commented Oct 22, 2025

/backport to stable32

@backportbot backportbot bot mentioned this pull request Oct 22, 2025
Merged
@nextcloud nextcloud deleted a comment from backportbot bot Oct 22, 2025
@AndyScherzinger AndyScherzinger added this to the Nextcloud 33 milestone Oct 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@provokateurin provokateurin Awaiting requested review from provokateurin

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish 32-feedback bug feedback-requested

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

4 participants

@mickenordin @nickvergessen @AndyScherzinger