fix(files-external): do not load lazy appconfig from construct #55830
+22
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtificialOwl
requested review from
icewind1991,
nfebe and
provokateurin
and removed request for
a team
ArtificialOwl
force-pushed
the
fix/noid/lazy-from-construct
branch
from
cabcc13 to
aac9fa5
Compare
come-nc
reviewed
Oct 21, 2025
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
This is taken care of by lazy ghosts on PHP >= 8.4, at least when no methods at all are called on the service.
artonge
reviewed
Oct 21, 2025
ArtificialOwl
force-pushed
the
fix/noid/lazy-from-construct
branch
from
aac9fa5 to
187edfb
Compare
Member
Author
|
artonge
approved these changes
Oct 22, 2025
come-nc
approved these changes
Oct 23, 2025
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
ArtificialOwl
force-pushed
the
fix/noid/lazy-from-construct
branch
from
187edfb to
07d3f1c
Compare
Member
Author
|
/backport to stable32 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid reaching lazy appconfig from
__construct()retrieve and cache values are initiated from method needing those config