fix(lexicon): switch bool value to non-lazy #55864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtificialOwl
requested review from
Altahrim,
come-nc and
yemkareems
and removed request for
a team
Member
Author
|
/backport to stable32 |
ArtificialOwl
force-pushed
the
fix/noid/tmp-switch-to-non-lazy
branch
from
36987f8 to
a7e7ca5
Compare
nickvergessen
approved these changes
Oct 21, 2025
core/AppInfo/ConfigLexicon.php
Outdated
Comment on lines
94
to
95
| new Entry(self::OCM_DISCOVERY_ENABLED, ValueType::BOOL, true, 'enable/disable OCM', lazy: false), | ||
| new Entry(self::OCM_INVITE_ACCEPT_DIALOG, ValueType::STRING, '', 'route to local invite accept dialog', lazy: false, note: 'set as empty string to disable feature'), |
Member
There was a problem hiding this comment.
Since it's the default:
Suggested change
| new Entry(self::OCM_DISCOVERY_ENABLED, ValueType::BOOL, true, 'enable/disable OCM', lazy: false), | |
| new Entry(self::OCM_INVITE_ACCEPT_DIALOG, ValueType::STRING, '', 'route to local invite accept dialog', lazy: false, note: 'set as empty string to disable feature'), | |
| new Entry(self::OCM_DISCOVERY_ENABLED, ValueType::BOOL, true, 'enable/disable OCM'), | |
| new Entry(self::OCM_INVITE_ACCEPT_DIALOG, ValueType::STRING, '', 'route to local invite accept dialog', note: 'set as empty string to disable feature'), |
nickvergessen
approved these changes
Oct 21, 2025
come-nc
approved these changes
Oct 21, 2025
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
ArtificialOwl
force-pushed
the
fix/noid/tmp-switch-to-non-lazy
branch
from
a7e7ca5 to
1329091
Compare
Member
Author
|
(removing default value for lazy parameter) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From internal discussion with @nickvergessen it felt better to switch those boolean config value to non-lazy as most of them are loaded during discovery request and looking for lazy config value at that point might be counter-efficient.
This PR also contains the laziness migration to already stored value in database, using the Lexicon, on the upgrade of core and/or apps.
And remove the laziness migration pre-lexicon.