refactor: apply rector rules for PHPUnit 10 #55882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
3. to review
susnux
force-pushed
the
chore/rector-phpunit-11
branch
6 times, most recently
from
f83d916 to
79f0299
Compare
susnux
requested review from
a team,
ChristophWurst,
SebastianKrupinski,
hamza221,
kesselb,
miaulalala,
nickvergessen,
st3iny and
tcitworld
as code owners
susnux
requested review from
ArtificialOwl,
CarlSchwan and
provokateurin
and removed request for
a team
susnux
force-pushed
the
chore/rector-phpunit-11
branch
from
79f0299 to
de9ce75
Compare
kesselb
approved these changes
Oct 22, 2025
miaulalala
previously requested changes
Oct 22, 2025
tests/lib/AppFramework/Utility/ControllerMethodReflectorTest.php
Outdated
Show resolved
Hide resolved
nickvergessen
approved these changes
Oct 22, 2025
susnux
force-pushed
the
chore/rector-phpunit-11
branch
from
ad105b0 to
1ebbe04
Compare
Contributor
Author
This test was never run before on Oracle due to wrong annotation -> was included in no-db group. |
Member
|
So either fix or skip if DB is oracle and fix it soon 🙈 |
susnux
force-pushed
the
chore/rector-phpunit-11
branch
from
1ebbe04 to
0a20f2e
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Both are basically special groups, which we do not use. But they also had a special meaning in the past which now only works when set on the test class: They set the test timeout. So for `@small` we just remove them, for `@medium` we remove where not needed but keep it on the class where the full test class might make use of the adjusted timeout. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
chore/rector-phpunit-11
branch
from
0a20f2e to
c99d274
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Apply rector rules for PHPUnit 10, meaning resolving deprecation in v10 so the transit to v11 will be smoother.
Checklist
3. to review, feature component)stable32)