fix: Make federation TrustedServers dependency optional in RemotePlugin #55893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The federation app is not always installed, causing QueryException when `OCA\Federation\TrustedServers` is injected as a hard dependency. Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
force-pushed
the
fix/federation-optional-dependency
branch
from
1a7b42b to
3276aff
Compare
This was referenced Oct 21, 2025
artonge
approved these changes
Oct 22, 2025
nickvergessen
approved these changes
Oct 22, 2025
nfebe
added a commit
that referenced
this pull request
Nov 11, 2025
The federation app is not always installed, causing errors when TrustedServers is injected as a hard dependency. This change makes the dependency optional by using nullable types and null-safe operators, defaulting to false when unavailable. Modified backport of #55893 which are required for the stable31 backport to function correctly.
nfebe
added a commit
that referenced
this pull request
Nov 11, 2025
The federation app is not always installed, causing errors when TrustedServers is injected as a hard dependency. This change makes the dependency optional by using nullable types and null-safe operators, defaulting to false when unavailable. Modified backport of #55893 which are required for the stable31 backport to function correctly. Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
added a commit
that referenced
this pull request
Nov 11, 2025
The federation app is not always installed, causing errors when TrustedServers is injected as a hard dependency. This change makes the dependency optional by using nullable types and null-safe operators, defaulting to false when unavailable. Modified backport of #55893 which are required for the stable31 backport to function correctly. Signed-off-by: nfebe <fenn25.fn@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The federation app is not always installed, causing QueryException when
OCA\Federation\TrustedServersis injected as a hard dependency.See : https://github.com/nextcloud/server/pull/55080/files#r2438677009
Thanks to @nickvergessen for catching this.