Skip to content

Conversation

@artonge
Copy link
Contributor

@artonge artonge commented Oct 23, 2025

@artonge artonge force-pushed the artonge/refactor/port_files_version_to_vue3 branch 2 times, most recently from ff550d5 to 046c7d1 Compare October 23, 2025 17:52
@artonge artonge changed the title Artonge/refactor/port_files_version_to_vue3 refactor(files_versions): Migrate to Vue3 Oct 23, 2025
@artonge artonge force-pushed the artonge/refactor/port_files_version_to_vue3 branch 2 times, most recently from 911f4bd to a81bcd1 Compare October 23, 2025 17:59
@artonge artonge self-assigned this Oct 23, 2025
@artonge artonge added 3. to review Waiting for reviews javascript ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) technical debt labels Oct 23, 2025
@artonge artonge added this to the Nextcloud 33 milestone Oct 23, 2025
@artonge artonge requested a review from susnux October 23, 2025 18:01
@artonge artonge marked this pull request as ready for review October 23, 2025 18:01
@artonge artonge requested review from a team and skjnldsv as code owners October 23, 2025 18:01
@artonge artonge requested review from Altahrim, leftybournes, salmart-dev, szaimen and yemkareems and removed request for a team, Altahrim, salmart-dev, skjnldsv, szaimen and yemkareems October 23, 2025 18:01
@artonge artonge requested review from skjnldsv and removed request for leftybournes October 23, 2025 18:01
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@artonge artonge force-pushed the artonge/refactor/port_files_version_to_vue3 branch 2 times, most recently from 3e1bfec to 35fafb6 Compare October 24, 2025 14:44
Signed-off-by: Louis Chmn <louis@chmn.me>
And use proper optional argument syntax for its constructor

Signed-off-by: Louis Chmn <louis@chmn.me>
@artonge artonge force-pushed the artonge/refactor/port_files_version_to_vue3 branch from 35fafb6 to a078447 Compare October 24, 2025 15:00
Signed-off-by: Louis Chmn <louis@chmn.me>
@artonge artonge force-pushed the artonge/refactor/port_files_version_to_vue3 branch from a078447 to 8dc64d7 Compare October 24, 2025 15:47
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@susnux susnux merged commit 1d4d6ca into master Oct 27, 2025
210 of 214 checks passed
@susnux susnux deleted the artonge/refactor/port_files_version_to_vue3 branch October 27, 2025 13:16
@susnux susnux moved this to ☑️ Done in 📁 Files team Jan 5, 2026
@github-project-automation github-project-automation bot moved this from ☑️ Done to 🏗️ In progress in 📁 Files team Jan 5, 2026
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 6, 2026
@sorbaugh sorbaugh moved this from 🏗️ In progress to ☑️ Done in 📁 Files team Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews javascript ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) technical debt ❄️ 2026-Winter

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

4 participants