Skip to content

Conversation

@AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Oct 27, 2025

  • Resolves: see screenshot
    1024-2253

Summary

Share expiry icon has been missed to be replaced with the outline variant

TODO

  • backport to v32

Checklist

@AndyScherzinger AndyScherzinger added this to the Nextcloud 33 milestone Oct 27, 2025
@AndyScherzinger AndyScherzinger requested a review from a team as a code owner October 27, 2025 08:24
@AndyScherzinger AndyScherzinger added design Design, UI, UX, etc. 3. to review Waiting for reviews feature: sharing labels Oct 27, 2025
@AndyScherzinger AndyScherzinger requested review from artonge, kra-mo, sorbaugh and szaimen and removed request for a team October 27, 2025 08:24
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger force-pushed the style/noid/outlineShareExpiryIcon branch from 675cdc6 to 67b8be5 Compare October 27, 2025 15:29
@AndyScherzinger
Copy link
Member Author

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@AndyScherzinger AndyScherzinger merged commit adc2012 into master Oct 27, 2025
134 of 137 checks passed
@AndyScherzinger AndyScherzinger deleted the style/noid/outlineShareExpiryIcon branch October 27, 2025 18:11
@AndyScherzinger
Copy link
Member Author

/backport 67b8be5 to stable32

@backportbot
Copy link

backportbot bot commented Oct 27, 2025

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/56019/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 67b8be59

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/56019/stable32

Error: Failed to check for changes with origin/stable32: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants