fix(Dav): make absenceform textarea not overlap #56055
Conversation
GVodyanov
requested review from
artonge,
sorbaugh and
szaimen
and removed request for
a team
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
LGTM from screenshot but did not test
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Can’t see the autosize connection but if that automatically works on this, consider it an approval. :)
No this isn't autosize, it's just 6 rows, and after that you get a scrollbar. Speaking of autosize I would propose to add it as a feature to |
GVodyanov
force-pushed
the
fix/textarea-overlap
branch
from
e14edf1 to
0393ed2
Compare
Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
GVodyanov
force-pushed
the
fix/textarea-overlap
branch
from
0393ed2 to
d32ffe5
Compare
Should be fixed now |
|
/compile / |
| @search="asyncFind" /> | ||
| <NcTextField v-model="status" :label="t('dav', 'Short absence status')" :required="true" /> | ||
| <NcTextArea v-model="message" :label="t('dav', 'Long absence Message')" :required="true" /> | ||
| <div class="absence-long-message__wrapper"> |
There was a problem hiding this comment.
Any DOM node within a block can be an element. Within a given block, all elements are semantically equal.
Elements should be inside blocks not the other way around
There was a problem hiding this comment.
Maybe just rename to
absence-long-messageabsence-long-message__input
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
good expect inverted BEM.
@GVodyanov Sounds good to me – we should indeed probably always have autosize on textareas, regardless of the place. Is there an issue in the components repo with the technical details already? |
Fix #56156
Summary
Checklist
3. to review, feature component)stable32)